Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Question for a text string #131

Closed
Valdnet opened this issue Mar 22, 2021 · 4 comments · Fixed by #136
Closed

l10n: Question for a text string #131

Valdnet opened this issue Mar 22, 2021 · 4 comments · Fixed by #136

Comments

@Valdnet
Copy link
Contributor

Valdnet commented Mar 22, 2021

Is this text string correct?

$this->l10n->t('signed.%s', $originalFile->getExtension()),

My guess is it is because it is the name of the file with the extension, but when translating in Transifex, translators can make mistakes and add a space between signed. and %s.

I propose to separate the translation of the word signed from .%s.

@vitormattos
Copy link
Member

vitormattos commented Mar 22, 2021

Maybe remove the extension and keep only the translation of the word signed.
What do you think?

@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 22, 2021

In Transifex, the text string looks like this:

obraz

This can be a problem for translators. No There is such a combination in translations.
I propose to extract only signed beyond the .%s', $originalFile->getExtension()), code so that the bot will only scan that text string signed.

@vitormattos
Copy link
Member

vitormattos commented Mar 22, 2021

Proposal:

$this->l10n->t('signed') . '.', $originalFile->getExtension()

@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 22, 2021

I think it will be fine now and the bot will only scan signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants