Function bms_soc_update no longer called post-zephyr bms driver update

[pasrom]

After the recent Zephyr driver update (commit f0ff664), the bms_soc_update function seems to have stopped being invoked. This has led to the State of Charge (SoC) no longer being calculated. Prior to this update, the function was regularly called at this location:

bms-firmware/app/src/bq769x2/bms_bq769x2.c

Lines 154 to 162 in 39bbaea

	void bms_update(Bms *bms)
	{
	bms_read_voltages(bms);
	bms_read_current(bms);
	bms_soc_update(bms);
	bms_read_temperatures(bms);
	bms_update_error_flags(bms);
	bms_update_balancing(bms);
	}

Could you advise on the best location for invoking bms_soc_update in the current code framework to maintain precise SoC measurements?

[pasrom]

I recommend placing the call to bms_soc_update(&bms) before line 66, where bms_state_machine(&bms) is called.

bms-firmware/app/src/main.cpp

Lines 61 to 66 in f0ff664

	err = bms_ic_read_data(bms_ic, BMS_IC_DATA_ALL);
	if (err != 0) {
	LOG_ERR("Failed to read data from BMS IC: %d", err);
	}
	bms_state_machine(&bms);

[martinjaeger]

Thanks for raising the issue. I'm planning to do some further BMS testing tomorrow anyway, so I'll have al look into that.

[martinjaeger]

I agree with your proposed fix and have created a PR (see link above).