Use uClibc to build libressl will get error: uClibc on noMMU doesn't provide __register_atfork()

[redbirdtek]

#ifdef GLIBC
extern void __dso_handle;
extern int __register_atfork(void ()(void), void()(void), void ()(void), void *);
#define _ARC4_ATFORK(f) __register_atfork(NULL, NULL, (f), __dso_handle)
#else
#define _ARC4_ATFORK(f) pthread_atfork(NULL, NULL, (f))
#endif

[kinichiro]

I found same kind of issue. https://gitlab.freedesktop.org/ffontaine/libbsd/commit/1220b3b758030f1717558980d60ade9a33628383 Using pthread_atfork would solve this with uClibc on noMMU ?

…

[redbirdtek]

I found same kind of issue. https://gitlab.freedesktop.org/ffontaine/libbsd/commit/1220b3b758030f1717558980d60ade9a33628383 Using pthread_atfork would solve this with uClibc on noMMU ?
…

Yes, code-building pass if use pthread_atfork,hope someone can fix this issue in the master branch.

[kinichiro]

Does this arc4random_linux.h patch work for you with uClibc ?
And regression tests succeed ?

--- crypto/compat/arc4random_linux.h.orig	Mon Jul  1 20:23:38 2019
+++ crypto/compat/arc4random_linux.h	Mon Jul  1 20:25:37 2019
@@ -32,7 +32,7 @@ static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_
 #define _ARC4_LOCK()   pthread_mutex_lock(&arc4random_mtx)
 #define _ARC4_UNLOCK() pthread_mutex_unlock(&arc4random_mtx)
 
-#ifdef __GLIBC__
+#if defined(__GLIBC__) && !defined(__UCLIBC__)
 extern void *__dso_handle;
 extern int __register_atfork(void (*)(void), void(*)(void), void (*)(void), void *);
 #define _ARC4_ATFORK(f) __register_atfork(NULL, NULL, (f), __dso_handle)

I had tested this diff by travis-ci here, to verify before send this to upstream.
To test in travis-ci, I put this diff as patches/arc4random_linux.h.patch.
https://travis-ci.org/kinichiro/portable/builds/552726084

[busterb]

That works fine for me. I think we intended for arc4random_linux.h to be able to work without any autoconf help since it lives upstream in the openbsd source, or I might have suggested a symbol check in the configuration phase instead.

[kinichiro]

Shall I suggest upstream change for arc4random_linux.h in ML ?

[busterb]

Sounds like the right thing to do. That'll fixup any other users as well on uclibc.

[kinichiro]

@redbirdtek
commit libressl/openbsd@8fa1a42 fixes this issue.
I'll close this issue.