Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "SSL_CTX_add_server_custom_ext" #55

Open
fancycode opened this issue Oct 22, 2015 · 6 comments
Open

Support "SSL_CTX_add_server_custom_ext" #55

fancycode opened this issue Oct 22, 2015 · 6 comments
Assignees

Comments

@fancycode
Copy link

It would be nice if LibreSSL could support SSL_CTX_add_server_custom_ext which is required for example in the nginx-ct module to enable certificate transparency.

I know that LibreSSL was forked from OpenSSL 1.0.1 and the feature was added in 1.0.2 - are there any plans to backport this?

@4a6f656c
Copy link

Not immediately - there is a fair amount of work required to support this. Additionally, adding the ability to inject and handle custom TLS extensions raises some concerns regarding attack surface. That said, since you've pointed out an actual use case take a closer look and see if there is a middle ground.

@gbilic
Copy link

gbilic commented Dec 17, 2015

BoringSSL introduced SSL_CTX_set_signed_cert_timestamp_list function to specifically handle signed certificate timestamps, my fork of nginx-ct makes use of it.

@fancycode
Copy link
Author

@gbilic thanks, unfortunately LibreSSL also doesn't support SSL_CTX_set_signed_cert_timestamp_list

@thefangbear
Copy link

I would also like Libressl to add this function.

@technion
Copy link

technion commented Nov 4, 2017

Just to update with a specific use case, see build notes here:

https://github.com/grahamedgecombe/nginx-ct

@4a6f656c
Copy link

While we're now in a position where we could consider adding this, it would require a reasonable amount of additional code and complexity to support.

Is anyone aware of any valid use case for SSL_CTX_add_{,client,server}_custom_ext() outside of nginx-ct? If not, providing SSL_CTX_set_signed_cert_timestamp_list() is likely
far preferable...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants