Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall target should maybe only be generated if installed? #1004

Closed
d3x0r opened this issue Feb 21, 2024 · 4 comments
Closed

uninstall target should maybe only be generated if installed? #1004

d3x0r opened this issue Feb 21, 2024 · 4 comments

Comments

@d3x0r
Copy link
Contributor

d3x0r commented Feb 21, 2024

https://github.com/libressl/portable/blob/master/CMakeLists.txt#L530-L543

I would think that if(NOT TARGET uninstall) section should be included in the block above it if(ENABLE_LIBRESSL_INSTALL) such that if there is no install, then no uninstall should be generated?

@d3x0r
Copy link
Contributor Author

d3x0r commented Mar 19, 2024

Here's a visual of generated projects - at the end is 'uninstall' which comes from libressl.

image

The option to skip install is on, because I'm just linking against the static libraries that are built, so there's no install to do, therefore there should also be nothing to uninstall...

@botovq
Copy link
Contributor

botovq commented Mar 19, 2024 via email

@botovq
Copy link
Contributor

botovq commented Apr 8, 2024 via email

@d3x0r
Copy link
Contributor Author

d3x0r commented Apr 8, 2024

yes

@botovq botovq closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants