[Menu] Have "Save Controller Profile" say: Saved "[Controller driver directory]/[File]" in the Controller Profile Directory.

[davidhedlund]

Current

Settings -> Input -> RetroPad Binds -> Port 1 Controls -> Save Controller Profile says "Controller profile saved successfully.", see bottom left on the screenshot:

Feature request

I suggest that Settings -> Input -> RetroPad Binds -> Port 1 Controls -> Save Controller Profile should say "Saved new controller profile to [controller profile directory]/[device driver]/[$input_device].cfg.".

Image manipulate example of the bottom of the screenshot:

This will make sure that people find the .cfg file, which is needed if they want to upload it for retroarch-joypad-autoconfig.

I spent about 24 hours coding a bash script used to generate dedicated autoconfig files, since I thought that "Save Controller Profile" was saved to retroarch.cfg. My script is useless since "Save Controller Profile" is actually already generating dedicated autoconfig files. However, this could have been prevented if the pop-up notification included the file path name. With that said, it's important that this issue becomes fixed to prevent other people from being confused in that want to upload autoconfig files. This issue is listed in:

• [Menu] Menu sub label finetunes and file names in on-screen notifications #16146

Main Menu -> Configuration -> Save Current Configuration displays [directory/file] so its source code can be reused.

Proposed 1 (new)

Example:

• Saved "udev/Sony Interactive Entertainment DualSense Wireless Controller.cfg" in Controller Profile directory.

Proposed 2 (old)

Related issues

Smartphones with average screen size are too narrow, so this issue must be solved to make display the full text:
#16147

Version/Commit

You can find this information under Information/System Information

• RetroArch: 1.16.0

Environment information

• OS: [The operating system you're running]
• Compiler: [In case you are running local builds]

[davidhedlund]

• [TOP PRIORITY] Generating a controller profile: Mention where the file will be saved docs#909

[davidhedlund]

@RobLoach Since it costed me at least 24 hours of development time to make a script that turned out to be useless since RA already can do this, can we please implement this ASAP?

Also, it will help all users to find where the generated .cfg file is, which will prevent them from creating .cfg files from scratch by scraping variables from retroarch.cfg.

[RobLoach]

It saves the controller profile autoconfigs when you select Save to Controller Profile.

Configuration File > Save config will save RetroArch.cfg, with your controller settings. We could add the file that it saves in the description too.

Is there anything that appears in the console logs when run with --verbose?

[davidhedlund]

We could add the file that it saves in the description too.

"Main Menu -> Configuration File -> Save Current Configuration" already show where the file is saved:

However, "Settings -> Input -> RetroPad Binds -> Port 1 Controls -> Save Controller Profile" does not mention where the file is saved, so I propose that. This is what this issue is about.

Is there anything that appears in the console logs when run with --verbose?

No, I don't get any output in the terminal when I:

• /RetroArch-Linux-x86_64.AppImage --verbose
• Settings -> Input -> RetroPad Binds -> Port 1 Controls -> Set all Controls
• Settings -> Input -> RetroPad Binds -> Port 1 Controls -> Save Controller Profile

[davidhedlund]

Thank you very much for adding the label!

[davidhedlund]

• [feature request]: Include directory name and .cfg file name in the controller notification message #15993

[davidhedlund]

• [Menu] Menu sub label finetunes and file names in on-screen notifications #16146

[davidhedlund]

@zoltanvb It should be very easy to display the saved file name to begin with. What do you think about it?

This will help people to find the autoconfig, which also is helpful for people who want to contribute to https://github.com/libretro/retroarch-joypad-autoconfig

[zoltanvb]

I am investigating the issue, but got a bit stuck when trying to find out why sublabels do not appear in normal binds, only in quick menu :) Anyway, it is not forgotten, I just want to explore a few options for displaying it, as the popup messages are fading quick and may not help a casual user too much identifying a possibly quite long file name.

[davidhedlund]

@zoltanvb It should be very easy to display the saved file name to begin with. What do you think about it?

Sorry, the directory path must be included as well, in order to distinguish it if the same config file name occur in multiple directories, which sometimes happen: This should be commented in the source code file(s) for "Save Controller Profile".

Do you know which source code file that are involved when "Save Controller Profile" is activated to display "Controller profile save successfully."? @zoltanvb

[zoltanvb]

The message display is here:

RetroArch/menu/menu_setting.c

Line 2531 in b209a26

runloop_msg_queue_push(

[davidhedlund]

The message display is here:

RetroArch/menu/menu_setting.c

Line 2531 in b209a26

runloop_msg_queue_push(

Thank you.

[davidhedlund]

@zoltanvb Does your commit add "[dir]/[file]" to the pop-up notification message seen at the bottom of the screenshot (copied from the top post)?:

Main Menu -> Configuration -> Save Current Configuration does that, so its source code could be reused for Settings -> Input -> RetroPad Binds -> Port 1 Controls -> Save Controller Profile

[zoltanvb]

No, it does not. I want to get some feedback with the PR before building on top of it.

Unfortunately it is not simple to reuse that, config saving is implemented via command structure, controller profile saving is direct.

[davidhedlund]

No, it does not. I want to get some feedback with the PR before building on top of it.

Unfortunately it is not simple to reuse that, config saving is implemented via command structure, controller profile saving is direct.

Oh, I see.

Once this has been fixed, I'll take a screenshot of the pop-up notification message and upload it to https://www.retroarch.com/index.php?page=controller-autoconfig, in order to visually guide people how to find the generated autoconfig file (since this issue killed 24 hours of useless Bash scripting for me).

I deeply appreciate your contributions to solve this issue!

[odditude42]

recommendation (if this isn't already implemented elsewhere) - i'd suggest generally using "saved %file% to %path%" instead of "saved %path%/%file%" - this way, the most significant info is at the front of the notification.

[davidhedlund]

recommendation (if this isn't already implemented elsewhere) - i'd suggest generally using "saved %file% to %path%" instead of "saved %path%/%file%" - this way, the most significant info is at the front of the notification.

Yeah. See:

• On-Screen notification widget: Add file names and Directory Titles #16222

[RobLoach]

File paths often get really ugly as demonstrated in #16121 (comment) . Could we keep this user-friendly and say "...in the Controller Profiles Directory" instead? If people want to know where that is, they can visit the Directory Settings.

[davidhedlund]

File paths often get really ugly as demonstrated in #16121 (comment) . Could we keep this user-friendly and say "...in the Controller Profiles Directory" instead? If people want to know where that is, they can visit the Directory Settings.

I added this to the top post as a new suggestion: