Sublabels for input bind common entries #16242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the port-specific indexes, sublabels for these entries are handled specially. Some simplification/generalization was applied and hand-crafted string joining was removed from a few places, though it remains still in other places. Preparation for libretro#16121 (this commit does not do anything yet with file names).
Removed a few labels, now unused, and the left/right check, as it fell back to the default which is given anyway in advance.
|
Please add "Mouse Index" sublabel too, since now in Ozone it looks out of place: |
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the port-specific indexes, sublabels for these entries are handled specially. Some simplification/generalization was
applied and hand-crafted string joining was removed from menu parts. Left/right part served no purpose nowadays, as it bound the default, which was bound in general earlier.
I have checked Settings / Input / RetroPad Binds / Port x Inputs, and Quick Menu / Controls / Port x Controls, but let me know if these items appear in some other parts of the menu as well.
Related Issues
After 22f32bf, the analog-to-digital sublabel stopped working in Settings/Input. This is now fixed.
This also serves as preparation for #16121 , though this PR does not do anything with file names so it does not solve it.
Reviewers
@sonninnos if you have time to take a look.