Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Scan Directory Recursive #3139

Closed
RobLoach opened this issue Jun 22, 2016 · 11 comments
Closed

Make Scan Directory Recursive #3139

RobLoach opened this issue Jun 22, 2016 · 11 comments

Comments

@RobLoach
Copy link
Member

This has been discussed in a few different issues:

I thought I'd have specific issue, with a distinct goal to make Scan Directory go into sub-folders recursively.

Problem

When you add your collection, you use Scan Directory, and have to select each folder for every system. This takes time, and can be confusing when you see 10 different async actions running at the same time.

Proposed Solution

Make Scan Directory recursively go into child directories. Then to add your whole collection, you just have to select the parent folder, and it'll add all files and child folders' files to your playlists. To accomplish this, when scanning through and it files a folder, it would add the folder to the task queue, similar to just selecting Scan Directory on each child folder from the menu.

@yisraeldov
Copy link

This is something I have also wanted, and really seems like a trivial thing to implement ( although I haven't tried it myself ).

@brandleesee
Copy link

I am also in favour of recursive searches. It minimises confusion with newcomers and makes the task less tedious to those who have already used RA.

@kivutar
Copy link
Member

kivutar commented Jun 23, 2016

I'd also like this.

@mikebutash
Copy link

I'll vote for this as well, something of a pain adding directories individually.

Either way, it really needs a queuing mechanism for directory scans so they don't all pile one atop the other as you select directories. Doing so on a remote cifs/nfs share just dogs everything down on large directories all at the same time as I found it begins doing.

Getting enough scans going it seems to bug out and stop displaying progress of any of them until some finally complete, a global progress against said queue of items to be scanned would be better here, especially with the recursive that take a while.

@shinra358
Copy link

would love this feature.

inactive123 added a commit that referenced this issue Aug 21, 2016
recursively scan directories for database content, fixes issue #3139
@RobLoach
Copy link
Member Author

This works! Thanks a lot, @bparker06.... For those following along, this was done at #3412 .

@sergiobenrocha2
Copy link
Contributor

sergiobenrocha2 commented Aug 29, 2016

This is a interesting feature, but it should be optional (at least there should be a option to disable it)... I have some beta/hack roms inside each console folder, and I don't like to see them in the playlist. But yeah, it's a interesting feature for newcomers.

@RobLoach
Copy link
Member Author

I have some beta/hack roms inside each console folder, and I don't like to see them in the playlist.

Move them into a different location then? clrmamepro, or similar, would read them as part of the No-Intro DAT.

@sergiobenrocha2
Copy link
Contributor

Yup, that's my problem. I guess I'll get used with this new feature. At least people will complain less.

@RobLoach
Copy link
Member Author

RobLoach commented Aug 29, 2016

But, it does seem like it could be an option in the settings. Create a new issue in the queue! Add ability to disable recursive scanning (on by default).

@kivutar
Copy link
Member

kivutar commented Aug 29, 2016

I love recursive scanning :o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants