(GLSL) send rotation index to shader #12827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jdgleaver , should we still merge this? @Themaister any thoughts? |
|
@twinaphex I am not familiar enough with the shader implementation to comment on this PR. But I don't see anything objectionable here. |
|
Note that it only handles glsl, someone still needs to port this to other shader formats (not sure i'll have the time and knowledge to successfully do this) |
|
Alright, I'll finally merge this (belatedly). We still need an implementation of this for slang though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #12816
Even if the original issue with zfast was fixed in a simpler way, sending the rotation index still sounds like a good idea, it should give more flexibility for shader programming. Furthermore, the zfast fix might not be portable to all shaders using
gl_FragCoord.