Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental way to make max_swapchain=2 work Rpi with GLES on dispmanx #5564

Merged
merged 1 commit into from Oct 19, 2017
Merged

Conversation

vanfanel
Copy link
Contributor

On the Raspberry Pi, when using the propietary graphics stack, double buffer (low input lag) was only possible when using the plain dispmanx graphics backend. So the max_swapchain=2 option was ignored on this configuration.
With this small patch, eglSwapBuffers() is supposed to wait for vsync and NOT triple-buffer when max_swapchain=2. It was found out thanks to popcornmix on this thread:
raspberrypi/userland#432

@kivutar kivutar merged commit 628acf5 into libretro:master Oct 19, 2017
@kivutar
Copy link
Member

kivutar commented Oct 19, 2017

Thank you!

@vanfanel
Copy link
Contributor Author

@kivutar : I need someone with the proper equipment to test this. Do you know who could do it?

@dankcushions
Copy link
Contributor

@Brunnis did the great input lag tests before, but I'm not sure if they still have an RPi to test with?

I guess this should negatively impact performance? I have been meaning to create a testing script that uses verbose console logs to track framerates on a batch of games - seems like a good excuse to write it :)

@vanfanel
Copy link
Contributor Author

vanfanel commented Oct 19, 2017

@dankcushions : Brunnis is busy at the moment. This will only impact performance if max_swapchain=2, with default max_swapchain=3 there's no impact at all. Supposing this works, which I can't prove without empirical evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants