Initialize COM only once, globally #7969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently MSVC adds this by default or something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes all calls to CoInitialize/CoUninitialize from drivers and instead inits/deinits only once in main(). It is a common and recommended practice for libraries and components to require the caller to initialize COM for them instead of trying to initialize it yourself.
Also see this stackoverflow question which is the same issue we are having (but without an answer, unfortunately): https://stackoverflow.com/questions/2154151/coinitialize-couninitialize-calls-pairing
Related Issues
#7842
Reviewers
@bparker06 @twinaphex