correct BIOS typo in port from Medanfen #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2017
markwkidd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Mednafen standalone, the required BIOS filename for the PC-FX 1.00 BIOS is pcfx.rom.
In the process of porting from standalone to libretro, the MDFN_GetSettingS function was simplified from the original source (which provides settings for all of the systems that Mednafen emulates). Probably due to an errant copy paste or other oversight, the configuration variable name (pcfx.bios) was substituted for the filename (pcfx.rom) in this one line of code affected by the PR.
As a consequence, MDFN_GettingS unintentionally overrides another portion of the libretro port that does show the correct ROM filename: https://github.com/libretro/beetle-pcfx-libretro/blob/master/libretro.cpp#L989
This change would restore the behavior of the upstream code.
There are a few posts which go into more detail about this in the libretro-database Issue tracker: libretro/libretro-database#373 (comment)