match default audio behavior setting to upstream Mednafen #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like a similar situation to the BIOS ROM name issue from earlier this week: #15 In porting to libretro, the various 'get setting' functions were simplified to return only the values needed for that particular core. The default value in standalone Mednafen for this setting is 1, but it wound up as 0 in the port. http://mednafen.fobby.net/documentation/pcfx.html#Settings+Reference There are forums users who are experiencing the 'click' audio error which this PR should fix.
|
@retro-wertz I'm just noticing that you also have been tracking this concern. Apologies for not giving you credit in my initial description, but hopefully this merge addresses your concern about the audio click error too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a similar situation to the BIOS ROM name issue from earlier this week: #15
In porting to libretro, the various 'get setting' functions were simplified to return only the values needed for that particular core. The default value for pcfx.adpcm.suppress_channel_reset_clicks in Mednafen is 1, but it wound up as 0 in the libretro port. http://mednafen.fobby.net/documentation/pcfx.html#Settings+Reference
There are forums users who are experiencing the 'click' audio error which this PR should fix by restoring the value of 1.