Re-Add some Event Cycles that were removed #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added back the event cycles that were removed in commit 798fab9.
The first screen of Final Fantasy 7 could be fixed with the beetle interpreter by setting the event cycles to 768, but with the removal of some cycle options, this was no longer possible.
Lightrec and dynarec were unaffected since they both needed event cycles set to 1024 to fix the same screen.
The other added event cycles were added for consitency, since just adding 768 would look unusual, and in case there is another edge case with a different game.
Default cycles:
Cycles set to 768 with beetle interpreter (or 1024 with lightrec and dynarec):
