Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making slackbuilds for libretro cores I have to package the source code myself as cloning with git during the build process is not accepted as slackbuilds.org. During this process I remove the
.git
directory from the source directory as its not needed and can be very large for some cores (mame). However many libretro cores setGIT_VERSION
which adds a useful git hash in the RetroArch menu next to the version, but without the git directory the following error will be printed.This can be easily avoided by using ?= instead of := in the makefile and then adding the following to my slackbuilds which have the git hash already provided in the version.
Of course if GIT_VERSION is not set then the default behavior will still be used. If this is acceptable for libretro I will submit more PRs for other cores with time.