-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ready for review: Migration to Symfony 3 #37
base: master
Are you sure you want to change the base?
Conversation
.editorconfig
Outdated
- | ||
-; Unix-style newlines | ||
-[*] | ||
-end_of_line = LF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a broken diff/merge here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it
Can you try to check the code, for compatibility with the current state? |
Wow, nicely done! Getting the following error when attempting to create the database:
Know how to fix the database path? |
Ah. Git does not like empty folders. When you create the |
Remove PHP 5 support
|
Tonight I'll write tests for the other APIs. So we have 100% coverage. |
Very cool! I'll have another chance to test more tonight. |
@RobLoach Thanks :) Any feedback on #37 (comment) |
I got another idea. The old entries will be replaced. |
…miting entries per ip or ip username combo
The latest commit is ready for review. But needs tests for lifecycle callback and entrymanagementlistener so don't merge just yet. ;) |
It is ready for a review. |
Anything? |
Looks great from my perspective. Tested it a bit ago and entries were added correctly. Even set up an Apache local host and the routes picked up correctly. I'd be open to merging! @fr500, think we're ready? We could test this on a different branch on lobby.libretro.com if you want to make sure it works on the server beforehand. |
@bparker kinda took over and I'm not sure...
I think he rewrote the whole thing in Python
…On Mon, Mar 6, 2017, 1:15 AM Rob Loach ***@***.***> wrote:
Looks great from my perspective. Tested it a bit ago and entries were
added correctly. Even set up an Apache local host and the routes picked up
correctly.
I'd be open to merging! @fr500 <https://github.com/fr500>, think we're
ready? We could test this on a different branch on lobby.libretro.com if
you want to make sure it works on the server beforehand.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABpC0Dixo29Td288idzdMQqT5UCKggSfks5ri6SXgaJpZM4MEiqW>
.
|
@fr500 cool... |
Seems like @bparker06 didn't do anything in his fork. |
I am closing this PR due to the current state of this repository. |
it's not really our fault either, @RobLoach at least was aware that this thing was coded on a whim, on a weekend were I decided we were gonna have a netplay quick connect feature, he was available and he helped me with the PHP side of things. It was developed as a sort of proof of concept and nothing else. |
@fr500 Is there anything holding us back from merging this one though? It's a lot better then what's on lobby.libretro.com right now. Even though newlobby is coming, this will keep us going until it's switched with the Python one. Also, this has tests 😉 |
We migrated already... I don't know really, this is off my hands now |
Created this PR for you to keep track of what I am doing. Please don't be afraid to ask!
I will help where I can and add documenation where needed.