Add mamemess core for Android arm64 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should build a full mame-mess core for android arm64. It successfully compiled a v.251 mamemess core locally, tested it on my phone, and can confirm that it generally works. I tried to reproduce the way the CI system works as closely as possible, but someone with access to the CI system should double check that all goes smooth when moving the output files around. I'd be happy to hear back if this is acceptable or needs improvement. If given the green light, I am prepared to PR a core info file to libretro-super (and libretro?) Thanks for looking into this and thanks for the great work! Benjamin
eberhab
added a commit
to eberhab/libretro-super
that referenced
this pull request
Jan 13, 2023
Added a core info file for a proposed new mamemess core. This goes along with the mame PR: libretro/mame#342
|
Thanks for adding and testing the pipeline. If resulting core ends up being called just "mess" instead of "mamemess" one could probably just rename CORENAME="mess". Alternatively one could add an additional mv to android-make.yml. Or we are lucky and it works right away.. |
|
Seems like it failed? Happy to help debug. I'm also in discord. |
|
It seems like something unrelated failed in the pipeline and the mess core built just fine: https://git.libretro.com/libretro/mame/-/jobs/3018743 |
|
Ye I think it resolved itself after I let the ios core rebuild again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should build a full mame-mess core for android arm64. It successfully compiled a v.251 mamemess core locally, tested it on my phone, and can confirm that it generally works. I tried to reproduce the way the CI system works as closely as possible, but someone with access to the CI system should double check that all goes smooth when moving the output files around. I'd be happy to hear back if this is acceptable or needs improvement. If given the green light, I am prepared to PR a core info file to libretro-super (and libretro?) Thanks for looking into this and thanks for the great work! Benjamin