Cyclone and DrZ80 support #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arcadez2003 I think this would be good to merge. |
|
Alrighty then |
wn2000
reviewed
Mar 31, 2024
| for (i=0;i<MAX_CPU;i++) | ||
| { | ||
| unsigned int *type=(unsigned int *)&(Machine->drv->cpu[i].cpu_type); | ||
| if (type==CPU_Z80) |
There was a problem hiding this comment.
This seems to be a bug. It should be if (*type == CPU_Z80) (gcc does warn about comparison between a pointer and an int). So DRZ80 was never actually enabled because of this.
But after fixing this (as well as on line 887), I lost part of the sounds in games (e.g. sdfight), until DRZ80 is turned off.
@frangarcj hope you are still around to take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #765