[RFC] Fix Parallel-RDP on Intel Xe #388
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #383 ParaLLel-RDP crashes on current Intel Xe drivers. On newer drivers vkGetPhysicalDeviceMemoryProperties calls incorrectly populates the VkPhysicalDeviceMemoryProperties struct values meaning that all contained memoryTypes->propertyFlags fields return 1 instead of the or'd flag values.
This means that the find_memory_type method's lookups will never match based on the expected flags, the rdram buffer is not initialized and it crashes out.
This will force set the memoryTypes index to the appropriate value bypassing the lookup method if the driver vendor is Intel and the version is at least the current most one, 30.0.100.9862.