-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add complete support for "Rikki & Vikki" #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because SOUPER cartridges can trap MARIA's reads and handle them specially.
This is located at: http://tailchao.com/Audio/index.php#BupBoop It uses the zlib license, which is GPL compatible. This library is needed to emulate the sound hardware that "Rikki & Vikki" uses. It's an entirely separate chip included in the cartridge that produces 16-bit stereo audio. Note that BupBoop supplies a library called WinTone that provides DirectSound bindings, but we don't use it both because we already use DirectSound and because using WinTone would complicate `libretro` portability.
Note that this commit itself doesn't actually allow the BupChip to be used for anything, because the only way to supply music for the BupChip to play is through the CDF format.
This format allows song files to be supplied to the emulated BupChip for playback. It matches the format used by BupSystem: http://tailchao.com/BupSystem/index.php "Rikki & Vikki" is supplied as a CDF file, along with an unheadered `.bin` image and several music files.
This pull request introduces 3 alerts when merging 60de1d5 into fbf62c3 - view on LGTM.com new alerts:
|
This was referenced Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here's a pull request with complete support for "Rikki & Vikki", including music. It adds support for BupSystem's BIN/CDF format, so that you can open the Steam
FoxBox.cdf
in RetroArch and it should run fine. Note that you must addcdf
as a valid extension in the core info or RetroArch will refuse to open it.One of the commits contains a vendored copy of part of BupBoop, which is an emulation of the chip that this game uses. (The emulator, chip, and game were all written by the same author.) This library is under the zlib license, which is GPL compatible.
There is a corresponding upstream pull request that contains this same code, ported over to its style.
Closes #63.