-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N64 and MD/Gen 6B NSO Controller Profiles #801
N64 and MD/Gen 6B NSO Controller Profiles #801
Conversation
autoconf d-input profiles for the N64 and MD/Gen 6 Button pads (Japan version).
? |
@offalynne I believe that's to make it able to navigate the RetroArch menus more easily. A few of the N64 autoconfigs have that. @PitiBatou Yeah, that's a problem. if it has an identical vid/pid, we generally have to pick one of them and then comment out the vid/pid on any others. We hope to someday have a better way of identifying them, but in the meantime, if the device name matches exactly, I think it'll go ahead and match even with the vid/pid commented out...? |
On the N64 mapping:
This was lifted from the Hyperkin Adapter for N64 profile. As mentioned by @hizzlekizzle this makes menu navigation much easier. I happen to have the Hyperkin adapter as well and it works well. On the MD 6Button Profile: |
Deferring to the SNES labels for the config makes sense since they're a subset of the default Switch labels. Looks like L & R on the SNES Online pad are C and Z on the MD pad. Curious what it looks like for the Genesis 3 button variant, seems probable it's the same VID/PID as well. |
@hizzlekizzle Got my SNES Switch controller. I was able confirm the SNES and MD/Gen 6B pad share the same ids. Commenting out the ids to "swap" works just fine. @offalynne The mapping of 6 face button pads has always confused me. Should we prioritize mappings as physically close as possible to the virtual RetroPad layout or keep to the original platform layout? For MD/Gen 6 button or 8BitDo MT30, is it better to do: This makes SNES/PSX plug & play but MD/Gen confusing or Physical A,B,C as RetroPad Y,B,A This makes MD/Gen plug & play but SNES/PSX confusing I know this is why we have remaps but it would be nice to have something more automated for this kind of pads. (remaps strike me as an intermediate/advanced user feature?). Definitely a niche thing though as 6 face button pads are definitely not that common... Thanks both for your time! |
There's unfortunately no perfect solution, and the cores themselves even vary. That is, GPGX's 6-button mapping puts ABC on YBA, while Blastem puts them on BAR (IIRC). |
How is this looking? Good to meget? |
@hizzlekizzle These are Bluetooth controllers, so dinput reports both their names as "Wireless Gamepad" or "Wireless Controller". I don't know why Windows has this behaviour. Meanwhile, on udev on Linux, all the NSO controllers (SNES, Genesis/Mega Drive 3btn and 6btn, and N64) can be distinguished through their reported name, so this is not an issue there. |
@nfp0 Sorry for the late reply. Here is the code for both. I can confirm indeed that udev has no issue distinguishing between the SNES and MD controllers. Do you mind if I ask you to do the PR? I can't wrap my head around how to do a PR just for these two files...
|
@PitiBatou Thanks a lot! |
@nfp0 Got it! Done & done! |
@PitiBatou Nice. Thanks! |
Leave |
@offalynne That's right, the N64 VID & PID are unique. |
Is there anything stopping this from being merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sorry for the holdup, finally merged! |
autoconf d-input profiles for the N64 and MD/Gen 6 Button pads (Japan version).
Second commit:
EDIT: Looks like the 6 button MD vendor id and product id are the same as the SNES Switch controller. How do we address this kind of duplicates?