Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make virtual keyboard key presses work on both Joy 1 and Joy 2 #50

Closed
Gazdaman opened this issue May 20, 2018 · 1 comment · Fixed by #73
Closed

Make virtual keyboard key presses work on both Joy 1 and Joy 2 #50

Gazdaman opened this issue May 20, 2018 · 1 comment · Fixed by #73

Comments

@Gazdaman
Copy link

Virtual Keyboard key presses only seem to work when Joy 2 is the selected input method.

When I toggle to Joy 1 using the "RETROK_KP_MULTIPLY" key mapping and then try to type on the virtual keyboard, no key press is actuated from the controller. I need to toggle back to Joy 2 to make virtual keyboard presses work.

Please make it work whether Joy 1 or Joy 2 is the selected (toggled) input.
@rsn8887
Copy link
Collaborator

rsn8887 commented Jul 18, 2019 •
edited

It works with joy2 when you disable retrojoy in the menu. But then the joystick doesn't work. So to make it work with joy 2, currently, you have to disable retrojoy, use the virtual keyboard, then enable retrojoy again to use the joystick.

This explains the weird issue that pressing N on the virtual keyboard causes an automatic "Load" command sometimes. That only happens when joy 2 AND retrojoy are both enabled.

I agree this should be fixed but I don't know where the bug is at the moment.

rsn8887 added a commit to rsn8887/vice-libretro that referenced this issue Jul 25, 2019
@rsn8887
Fix keys not working, always allow dpad pointer, make gui usable
e2a6a83 
closes libretro#50
closes libretro#62
rsn8887 added a commit to rsn8887/vice-libretro that referenced this issue Jul 25, 2019
@rsn8887
Fix keys not working, always allow dpad pointer, make gui usable
77f8828 
closes libretro#50
closes libretro#62

- fix keys not working on virtual keyboard. This was because the
  joystick button press interfered with the virtual key press.
  Virtual keyboard keys now always work regardless of the
  joyport and retrojoy settings

- the gui menu can now be toggled off as well as on with the
  button mapped to the 'Vice menu' key (RETROK_KP_DIVIDE), which
  is the start button by default

- the gui menu and vkbd can now always be summoned, regardless
  of the value of the "vice_Controller" setting in quick menu

- the pointer in the gui menu and vkbd can now always be
  controlled via dpad (in addition to mouse control)

- the keys with additional meanings in quickmenu->options are now
  labeled for clarity. For example, `RETROK_KP_DIVIDE (Vice Menu)`
  instead of just `RETROK_KP_DIVIDE`, or
  `RETROK_F9 (Virtual Keyboard)` instead of just `RETROK_F9`
@rsn8887 rsn8887 mentioned this issue Jul 25, 2019
Merged
rsn8887 added a commit to rsn8887/vice-libretro that referenced this issue Jul 30, 2019
@rsn8887
Fix keys not working, always allow dpad pointer, make gui usable
6c1e0b2 
closes libretro#50
closes libretro#62

- fix keys not working on virtual keyboard. This was because the
  joystick button press interfered with the virtual key press.
  Virtual keyboard keys now always work regardless of the
  joyport and retrojoy settings

- the gui menu can now be toggled off as well as on with the
  button mapped to the 'Vice menu' key (RETROK_KP_DIVIDE), which
  is the start button by default

- the gui menu and vkbd can now always be summoned, regardless
  of the value of the "vice_Controller" setting in quick menu

- the pointer in the gui menu and vkbd can now always be
  controlled via dpad (in addition to mouse control)

- the keys with additional meanings in quickmenu->options are now
  labeled for clarity. For example, `RETROK_KP_DIVIDE (Vice Menu)`
  instead of just `RETROK_KP_DIVIDE`, or
  `RETROK_F9 (Virtual Keyboard)` instead of just `RETROK_F9`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix keys not working, always allow dpad pointer, make gui usable rsn8887/vice-libretro
2 participants
@Gazdaman @rsn8887