Fix keys not working, always allow dpad pointer, make gui usable #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes libretro#50 closes libretro#62 - fix keys not working on virtual keyboard. This was because the joystick button press interfered with the virtual key press. Virtual keyboard keys now always work regardless of the joyport and retrojoy settings - the gui menu can now be toggled off as well as on with the button mapped to the 'Vice menu' key (RETROK_KP_DIVIDE), which is the start button by default - the gui menu and vkbd can now always be summoned, regardless of the value of the "vice_Controller" setting in quick menu - the pointer in the gui menu and vkbd can now always be controlled via dpad (in addition to mouse control) - the keys with additional meanings in quickmenu->options are now labeled for clarity. For example, `RETROK_KP_DIVIDE (Vice Menu)` instead of just `RETROK_KP_DIVIDE`, or `RETROK_F9 (Virtual Keyboard)` instead of just `RETROK_F9`
|
@twinaphex ready to merge whenever you have time, thank you! |
This was referenced Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50
closes #62
Fix keys not working on virtual keyboard sometimes. This was because the
joystick button press interfered with the virtual key press.
Virtual keyboard keys now always work regardless of the
joyport and retrojoy settings
The gui menu can now be toggled off as well as on with the
button mapped to the
Vice menukey (RETROK_KP_DIVIDE), whichis mapped to the
startbutton by defaultThe gui menu and vkbd can now always be summoned, regardless
of the value of the
vice_Controllersetting in quick menuThe pointer in the gui menu and vkbd can now always be
controlled via dpad (in addition to mouse control), no need to press
selectto enable this functionality anymore.The keys with additional meanings in quickmenu->options are now
labeled for clarity. For example,
RETROK_KP_DIVIDE (Vice Menu)instead of just
RETROK_KP_DIVIDE, andRETROK_F9 (Virtual Keyboard)instead of justRETROK_F9etc.