Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added appveyor configuration #677

Merged
merged 3 commits into from
Feb 19, 2018
Merged

Added appveyor configuration #677

merged 3 commits into from
Feb 19, 2018

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented Feb 17, 2018 •
edited
Loading

What does this implement/fix? Explain your changes.

This PR adds Appveyor CI for testing on windows systems.

In setting up windows CI, a platform dependent bug in find_files was exposed #678 -- this PR includes a fix for that.

This change is Reviewable

@bmcfee bmcfee added the testing Issues with our test design and continuous integration services label Feb 17, 2018
@bmcfee bmcfee self-assigned this Feb 17, 2018
@bmcfee
Copy link
Member Author

bmcfee commented Feb 17, 2018

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented Feb 18, 2018

Tests are now failing because of implicit OS assumptions on paths to fixture files. This will take a bit of work to sort out, but at least the CI system is now in place.

@bmcfee
Copy link
Member Author

bmcfee commented Feb 18, 2018

upon closer inspection, it might be down to windows doing funny things with tempfile.mkstemp -- will investigate later.

@bmcfee
Copy link
Member Author

bmcfee commented Feb 18, 2018

This all appears to be working now. The only lingering exception is the unit test for util.find_files, which has a bunch of cases that test case-sensitivity. This clearly (expectedly) fails on windows, but the tests do not account for this. We'll need to put some os detection logic into the test, but this is pretty easy.

@bmcfee bmcfee mentioned this pull request Feb 18, 2018
Closed
@bmcfee bmcfee added the bug Something doesn't work like it should label Feb 18, 2018
@bmcfee bmcfee added this to the 0.6.1 milestone Feb 18, 2018
@bmcfee
Added appveyor configuration
4dc6c19 
trying to fix appveyor script

improved test portability for windows

improved test portability for windows

limited find_files unit tests for windows

debugging find_files test on windows
@bmcfee
updated badges [ci skip]
1e9a204
@bmcfee
Copy link
Member Author

bmcfee commented Feb 18, 2018

Reviewed 11 of 13 files at r2, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented Feb 18, 2018

Reviewed 2 of 2 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented Feb 18, 2018

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented Feb 19, 2018

Reviewed 1 of 1 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented Feb 19, 2018

Reviewed 1 of 1 files at r7.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented Feb 19, 2018

Reviewed 1 of 1 files at r8.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee
fixed #678 - dedupe results of find_files
5b2a5ad 
simplifying appveyor config

trying out conda caching in appveyor

trying out conda caching in appveyor

trying out conda caching in appveyor

trying out conda caching in appveyor

trying out conda caching in appveyor

fixing appveyor config

fixing appveyor config

disable fast_finish on appveyor [ci skip]

rewrote output tests using np.loadtxt for windows issues

rewrote output tests using csv reader for windows issues

one more try at conda caching on appveyor

one more try at conda caching on appveyor

wrestling with windows batch scripting

wrestling with windows batch scripting like it's 1992

debugging csv tests on windows [travis skip]

debugging csv tests on windows [travis skip]

debugging csv tests on windows [travis skip]

debugging csv tests on windows [travis skip]

py2/py3 compat in output testing again

debugging csv reader output

debugging csv reader output

skipping all non-output tests for now

removed csv reader from tests, trying again

debugging csv reader output

debugging csv reader output

fixed appveyor tests, finally
@bmcfee
Copy link
Member Author

bmcfee commented Feb 19, 2018

Reviewed 2 of 2 files at r9.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee bmcfee merged commit 24a081d into master Feb 19, 2018
@bmcfee bmcfee deleted the appveyor-setup branch February 19, 2018 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmcfee bmcfee

Labels
bug Something doesn't work like it should testing Issues with our test design and continuous integration services
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
1 participant
@bmcfee