Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #712, valid_intervals checks for non-negative durations #713

Merged
merged 2 commits into from
May 14, 2018
Merged

fixed #712, valid_intervals checks for non-negative durations #713

merged 2 commits into from
May 14, 2018

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented May 14, 2018 •
edited
Loading

Reference Issue

Fixes #713

What does this implement/fix? Explain your changes.

valid_intervals now checks for non-negative durations

Any other comments?

I'm okay to skip CR on this.

This change is Reviewable

@bmcfee bmcfee added the bug Something doesn't work like it should label May 14, 2018
@bmcfee bmcfee added this to the 0.6.1 milestone May 14, 2018
@bmcfee bmcfee self-assigned this May 14, 2018
@bmcfee
Copy link
Member Author

bmcfee commented May 14, 2018

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented May 14, 2018

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee bmcfee merged commit 0b4ae87 into master May 14, 2018
@bmcfee bmcfee deleted the valid-interval-strict branch May 14, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmcfee bmcfee

Labels
bug Something doesn't work like it should
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
1 participant
@bmcfee