Skip to content

Commit

Permalink
wikiheaders: Allow basic typedefs to pull in some preprocessor logic.
Browse files Browse the repository at this point in the history
Reference Issue #9557.

This lets SDL_AudioFormat have the `#if byteorder == lilendian` section.
  • Loading branch information
icculus committed Apr 25, 2024
1 parent a13bdee commit 6b1a98e
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 15 deletions.
3 changes: 2 additions & 1 deletion build-scripts/wikiheaders.pl
Expand Up @@ -860,6 +860,7 @@ sub print_undocumented_section {
}

# We assume any `#define`s directly after the typedef are related to it: probably bitflags for an integer typedef.
# We'll also allow lines that start with `#if` or `#else` or `#elif`
# Blank lines are allowed, anything else, even comments, are not.
my $blank_lines = 0;
my $lastpos = tell(FH);
Expand All @@ -869,7 +870,7 @@ sub print_undocumented_section {

if (/\A\s*\Z/) {
$blank_lines++;
} elsif (/\A\s*\#define\s+/) {
} elsif (/\A\s*\#(define|if|else|elif)(\s+|\Z)/) {
if ($blank_lines > 0) {
while ($blank_lines > 0) {
$additional_decl .= "\n";
Expand Down
19 changes: 10 additions & 9 deletions include/SDL3/SDL_audio.h
Expand Up @@ -98,6 +98,16 @@ typedef Uint16 SDL_AudioFormat;
#define SDL_AUDIO_F32LE 0x8120 /**< 32-bit floating point samples */
#define SDL_AUDIO_F32BE 0x9120 /**< As above, but big-endian byte order */

#if SDL_BYTEORDER == SDL_LIL_ENDIAN
#define SDL_AUDIO_S16 SDL_AUDIO_S16LE
#define SDL_AUDIO_S32 SDL_AUDIO_S32LE
#define SDL_AUDIO_F32 SDL_AUDIO_F32LE
#else
#define SDL_AUDIO_S16 SDL_AUDIO_S16BE
#define SDL_AUDIO_S32 SDL_AUDIO_S32BE
#define SDL_AUDIO_F32 SDL_AUDIO_F32BE
#endif


/* masks for different parts of SDL_AudioFormat. */
#define SDL_AUDIO_MASK_BITSIZE (0xFF)
Expand Down Expand Up @@ -218,15 +228,6 @@ typedef Uint16 SDL_AudioFormat;
*/
#define SDL_AUDIO_ISUNSIGNED(x) (!SDL_AUDIO_ISSIGNED(x))

#if SDL_BYTEORDER == SDL_LIL_ENDIAN
#define SDL_AUDIO_S16 SDL_AUDIO_S16LE
#define SDL_AUDIO_S32 SDL_AUDIO_S32LE
#define SDL_AUDIO_F32 SDL_AUDIO_F32LE
#else
#define SDL_AUDIO_S16 SDL_AUDIO_S16BE
#define SDL_AUDIO_S32 SDL_AUDIO_S32BE
#define SDL_AUDIO_F32 SDL_AUDIO_F32BE
#endif

/**
* SDL Audio Device instance IDs.
Expand Down
7 changes: 2 additions & 5 deletions include/SDL3/SDL_thread.h
Expand Up @@ -83,11 +83,7 @@ typedef enum SDL_ThreadPriority {
*/
typedef int (SDLCALL * SDL_ThreadFunction) (void *data);


#if (defined(SDL_PLATFORM_WIN32) || defined(SDL_PLATFORM_GDK)) && !defined(SDL_PLATFORM_WINRT)
/**
* \file SDL_thread.h
*
/*
* We compile SDL into a DLL. This means, that it's the DLL which
* creates a new thread for the calling process with the SDL_CreateThread()
* API. There is a problem with this, that only the RTL of the SDL3.DLL will
Expand All @@ -105,6 +101,7 @@ typedef int (SDLCALL * SDL_ThreadFunction) (void *data);
* Always use the _beginthread() and _endthread() of the calling runtime
* library!
*/
#if (defined(SDL_PLATFORM_WIN32) || defined(SDL_PLATFORM_GDK)) && !defined(SDL_PLATFORM_WINRT)
#define SDL_PASSED_BEGINTHREAD_ENDTHREAD

typedef uintptr_t (__cdecl * pfnSDL_CurrentBeginThread)
Expand Down

0 comments on commit 6b1a98e

Please sign in to comment.