Skip to content

Commit

Permalink
Added missing events in SDL event logging
Browse files Browse the repository at this point in the history
Also improved formatting for unknown events
  • Loading branch information
slouken committed May 14, 2024
1 parent be786ae commit 84fa11f
Showing 1 changed file with 18 additions and 2 deletions.
20 changes: 18 additions & 2 deletions src/events/SDL_events.c
Original file line number Diff line number Diff line change
Expand Up @@ -428,13 +428,22 @@ static void SDL_LogEvent(const SDL_Event *event)
break;
#undef PRINT_JBUTTON_EVENT

SDL_EVENT_CASE(SDL_EVENT_JOYSTICK_BATTERY_UPDATED)
(void)SDL_snprintf(details, sizeof(details), " (timestamp=%u which=%d state=%u percent=%d)",
(uint)event->jbattery.timestamp, (int)event->jbattery.which,
event->jbattery.state, event->jbattery.percent);
break;

#define PRINT_JOYDEV_EVENT(event) (void)SDL_snprintf(details, sizeof(details), " (timestamp=%u which=%d)", (uint)event->jdevice.timestamp, (int)event->jdevice.which)
SDL_EVENT_CASE(SDL_EVENT_JOYSTICK_ADDED)
PRINT_JOYDEV_EVENT(event);
break;
SDL_EVENT_CASE(SDL_EVENT_JOYSTICK_REMOVED)
PRINT_JOYDEV_EVENT(event);
break;
SDL_EVENT_CASE(SDL_EVENT_JOYSTICK_UPDATE_COMPLETE)
PRINT_JOYDEV_EVENT(event);
break;
#undef PRINT_JOYDEV_EVENT

SDL_EVENT_CASE(SDL_EVENT_GAMEPAD_AXIS_MOTION)
Expand Down Expand Up @@ -465,6 +474,9 @@ static void SDL_LogEvent(const SDL_Event *event)
SDL_EVENT_CASE(SDL_EVENT_GAMEPAD_REMAPPED)
PRINT_GAMEPADDEV_EVENT(event);
break;
SDL_EVENT_CASE(SDL_EVENT_GAMEPAD_UPDATE_COMPLETE)
PRINT_GAMEPADDEV_EVENT(event);
break;
SDL_EVENT_CASE(SDL_EVENT_GAMEPAD_STEAM_HANDLE_UPDATED)
PRINT_GAMEPADDEV_EVENT(event);
break;
Expand Down Expand Up @@ -615,8 +627,12 @@ static void SDL_LogEvent(const SDL_Event *event)

default:
if (!name[0]) {
SDL_strlcpy(name, "UNKNOWN", sizeof(name));
(void)SDL_snprintf(details, sizeof(details), " #%u! (Bug? FIXME?)", (uint)event->type);
if (event->type >= SDL_EVENT_USER) {
SDL_strlcpy(name, "USER", sizeof(name));
} else {
SDL_strlcpy(name, "UNKNOWN", sizeof(name));
}
(void)SDL_snprintf(details, sizeof(details), " 0x%x", (uint)event->type);
}
break;
}
Expand Down

0 comments on commit 84fa11f

Please sign in to comment.