SDL_RenderReadPixels: Wrong rect coordinates with software renderer

[SDLBugzilla]

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• Patch (SDL_renderer_sw.diff, text/plain, 2017-04-26 14:17:46 +0000, 905 bytes)

Reported in version: 2.0.4
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2016-05-08 21:24:07 +0000, Daniel wrote:

SDL_RenderReadPixels with SDL_RENDERER_SOFTWARE reads pixels from wrong coordinates.

SW_RenderReadPixels adjusts the rect coordinates according to the viewport. But since this is already done by SDL_RenderReadPixels, the final rect has x2 bigger X and Y.

On 2017-04-26 14:17:46 +0000, Daniel wrote:

Created attachment 2726
Patch

Here is a patch to fix the bug.

On 2017-08-11 18:54:37 +0000, Sam Lantinga wrote:

Fixed, thanks!
https://hg.libsdl.org/SDL/rev/62db9336e07b