Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port fcitx support to both fcitx 4 & 5 #3653

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

Port fcitx support to both fcitx 4 & 5 #3653

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.1
Reported for operating system, platform: Linux, x86_64

Comments on the original bug report:

On 2020-04-22 08:36:49 +0000, wrote:

Created attachment 4318
Patch to support fcitx 5

Due to the new major fcitx version is coming close, the existing code need to be ported to use new Fcitx dbus interface.

The new dbus interface is supported by both fcitx 4 and 5, and has a good side effect, which is that it will work with flatpak for free. Also the patch remove the dependency on fcitx header. Instead, it just hardcodes a few enum value in the code so need to handle the different header for fcitx4 or 5.

On 2020-05-10 03:25:56 +0000, Jerry Xiao wrote:

(In reply to wengxt from comment # 0)

Created attachment 4318 [details]
Patch to support fcitx 5

Due to the new major fcitx version is coming close, the existing code need
to be ported to use new Fcitx dbus interface.

The new dbus interface is supported by both fcitx 4 and 5, and has a good
side effect, which is that it will work with flatpak for free. Also the
patch remove the dependency on fcitx header. Instead, it just hardcodes a
few enum value in the code so need to handle the different header for fcitx4
or 5.

Nice job!

On 2020-05-11 04:47:37 +0000, wrote:

Created attachment 4337
Update the patch to support build with cmake

On 2020-05-11 21:31:29 +0000, Sam Lantinga wrote:

Patch added, thanks!
https://hg.libsdl.org/SDL/rev/a73b49512ba2
@cathaysia cathaysia mentioned this issue Dec 21, 2021
Closed
NickCao added a commit to NickCao/nixpkgs that referenced this issue Mar 12, 2023
@NickCao
SDL2: remove unnecessary dependency on fcitx
6ae4842 
SDL2 supports both fcitx 4 and fcitx 5 though the dbus interface,
and the dependency on fcitx headers has been removed instead of
hardcoding the constants.

Reference: libsdl-org/SDL#3653
NickCao added a commit to NickCao/nixpkgs that referenced this issue Mar 12, 2023
@NickCao
SDL2: remove unnecessary dependency on fcitx
892f0c4 
SDL2 supports both fcitx 4 and fcitx 5 though the dbus interface,
and the dependency on fcitx headers has been removed in favor of
hardcoding the constants.

Reference: libsdl-org/SDL#3653
@NickCao NickCao mentioned this issue Mar 12, 2023
Merged
12 tasks
anpin pushed a commit to anpin/nixpkgs that referenced this issue Mar 15, 2023
@NickCao @anpin
SDL2: remove unnecessary dependency on fcitx
63f009c 
SDL2 supports both fcitx 4 and fcitx 5 though the dbus interface,
and the dependency on fcitx headers has been removed in favor of
hardcoding the constants.

Reference: libsdl-org/SDL#3653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SDLBugzilla