Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace CMake options #4139

Closed
jonesmz opened this issue Feb 28, 2021 · 1 comment
Closed

Namespace CMake options #4139

jonesmz opened this issue Feb 28, 2021 · 1 comment
Assignees
@icculus
Milestone
2.0.18

Comments

@jonesmz
Copy link

jonesmz commented Feb 28, 2021

E.g. VIDEO_KMSDRM should be SDL_VIDEO_KMSDRM, and KMSDRM_SHARED should be SDL_VIDEO_KMSDRM_SHARED

The way things are now, it's very difficult to determine which options are from SDL and which options are from other projects in the same cmake build.
@slouken slouken added this to the 2.0.16 milestone Jul 23, 2021
@icculus
Copy link
Collaborator

icculus commented Jul 27, 2021

I agree, but changing this is going to be non-trivial, so we might bump this to 2.0.18.

@slouken slouken modified the milestones: 2.0.16, 2.0.18 Jul 28, 2021
@icculus icculus closed this as completed in 7850d0c Oct 5, 2021
dimhotepus pushed a commit to The-White-Box/SDL that referenced this issue Oct 9, 2021
@icculus @dimhotepus
cmake: Prefix all options with "SDL_"
85f7f49 
This makes it clear which options came from SDL's CMake project when
building SDL as a subdirectory of a parent CMake project.

Fixes libsdl-org#4139.
dimhotepus pushed a commit to The-White-Box/SDL that referenced this issue Oct 9, 2021
@icculus @dimhotepus
cmake: Prefix all options with "SDL_"
f6110ff 
This makes it clear which options came from SDL's CMake project when
building SDL as a subdirectory of a parent CMake project.

Fixes libsdl-org#4139.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icculus icculus

Labels
None yet
Projects
None yet
Milestone
2.0.18
Development

No branches or pull requests
3 participants
@icculus @jonesmz @slouken