Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious SDL_TEXTEDITING events on Windows #5022

Closed
slouken opened this issue Nov 27, 2021 · 1 comment
Closed

Spurious SDL_TEXTEDITING events on Windows #5022

slouken opened this issue Nov 27, 2021 · 1 comment
Assignees
@slouken
Labels
early in milestone This change should be made early in the milestone for additional testing
Milestone
3.x

Comments

@slouken
Copy link
Collaborator

slouken commented Nov 27, 2021

When we lose focus, IME_ClearComposition() is called, which calls SDL_SendEditingText() with an empty string. We always deliver this, even if there's currently no composition. We probably should change the code so we don't send duplicate editing text events.
@slouken slouken added this to the 2.0.20 milestone Nov 27, 2021
@slouken slouken self-assigned this Nov 27, 2021
@zreedy zreedy mentioned this issue Mar 4, 2022
Closed
@zreedy zreedy mentioned this issue Mar 11, 2022
Merged
@slouken slouken added the early in milestone This change should be made early in the milestone for additional testing label Mar 17, 2022
@slouken slouken modified the milestones: 2.0.22, 2.0.24 Mar 17, 2022
@slouken slouken modified the milestones: 2.24.0, 2.26.0 Aug 1, 2022
@slouken slouken modified the milestones: 2.26.0, 3.0 Oct 25, 2022
@slouken
Copy link
Collaborator Author

slouken commented Nov 4, 2023

I believe this is fixed in #5398, please reopen this if that's not the case.

@slouken slouken closed this as completed Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slouken slouken

Labels
early in milestone This change should be made early in the milestone for additional testing
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
1 participant
@slouken