IME Composition Truncation + Mouse Bugs #5378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed: Whitespace being striped from the end of IME strings incorrectly
Added: SDL_ClearComposition function + Fix event order when selecting candidates in Japanese IME
…characters being truncated
…here no spaces were typed. + Memory leaks
…ting a window is not necessarily accurate. For example; if a window is created from dragging out a gadget/tab, the mouse button is still held down and has not been released yet.
…nto zreedy-ime-feb22
sezero
reviewed
Mar 4, 2022
| SDL_DYNAPI_PROC(SDL_bool,SDL_IsTextInputActive,(void),(),return) | ||
| SDL_DYNAPI_PROC(SDL_bool,SDL_IsTextInputShown,(void),(),return) |
There was a problem hiding this comment.
Do not insert new procs, but append them in dynapi: running the gendynapi.pl perl script will do that for you.
sezero
reviewed
Mar 4, 2022
|
|
||
| // Get the correct caret position if we've selected a candidate from the candidate window | ||
| if (videodata->ime_cursor == 0 && length > 0) { | ||
| int32_t start = 0; |
There was a problem hiding this comment.
Why not using SDL's own Sint32 here?
sezero
reviewed
Mar 4, 2022
| WCHAR buffer[SDL_TEXTEDITINGEVENT_TEXT_SIZE]; | ||
| const size_t size = SDL_arraysize(buffer); | ||
| buffer[0] = 0; | ||
| WCHAR *buffer = 0; |
There was a problem hiding this comment.
NULL, really (and the same for s just above it)
sezero
reviewed
Mar 4, 2022
| @@ -173,6 +177,7 @@ WIN_ResetDeadKeys() | |||
|
|
|||
| GetKeyboardState(keyboardState); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Unwanted addition of a stray newline?
|
Way too many commits (some irrelevant, some already reverted) - can this not be rebased to current main and squashed? |
|
I did not realize you had made that change in main already! Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following issues:
IME Candidate/Submission Truncation
A new SDL hint flag
SDL_HINT_IME_SUPPORT_EXTENDED_TEXThas been added. When disabled (SDL_FALSE) legacy behavior is retained with no side-effects.When enabled (SDL_TRUE) the following occurs instead:
SDL_TextEditingExtEvent(SDL_TEXTEDITING_EXT) is issued if the buffer would overflow (previously truncated). Otherwise the originalSDL_TextEditingEventis still issued. This is to reduce the amount of heap allocation that needs to happen.SDL_TextInputEventwill be dispatched multiple times with as much text that can be stored in the text field buffer (32 bytes) as possible (respecting UTF-8 codepoint boundaries).The text field of
SDL_TextEditingExtEventmust be freed by the consumer, this is inline with the behavior ofSDL_FileDrop.Further details can be found in the thread for issue 5363
No way for an application to query if the IME candidate window is open
This is needed for software applications (and games) using SDL to interact with IME an appropriately. Without knowing if the IME is currently actively taking input from the user or displayed it's not possible for an application to handle certain input events from the mouse appropriately.
This was fixed by adding
SDL_IsTextInputShown. This returns an SDL_bool.No way for application to dismiss IME candidate window
This is needed for software applications (and games) using SDL to interact with an IME appropriately. When a user clicks somewhere within the application, it is important to instruct the IME to dismiss whatever candidate was provided without it dispatching events to the user. The added
SDL_ClearCompositiondoes this without the overhead of disabling/re-enabling the IME subsystem (which was previously required).Existing Issue(s)
SDL_ResetTextInputfunction #4847