Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X11: SDL_HideWindow and/or SDL_ShowWindow broken in 2.0.22 #5595

Closed
complexlogic opened this issue May 2, 2022 · 3 comments
Closed

X11: SDL_HideWindow and/or SDL_ShowWindow broken in 2.0.22 #5595

complexlogic opened this issue May 2, 2022 · 3 comments
Assignees
@icculus
Milestone
2.24.0

Comments

@complexlogic
Copy link

This is possibly related to #5572, but I'm going to make a separate issue just in case.

I'm on Arch Linux, and recently upgraded SDL to 2.0.22. My program Flex Launcher uses SDL to render 2D graphics. Basically, it's a full screen application launcher that hides its window while the launched application is running, and then shows itself again after the application finishes. It uses the functions SDL_HideWindow() and SDL_ShowWindow() to accomplish this.

However, since I upgraded SDL, I noticed that after the application finishes and SDL_ShowWindow() is called, the resulting window is just completely blank (when it should have the rendered graphics). I verified this issue on two different Arch Linux PCs, one with a KDE Plasma desktop, one with Openbox (both X11).

I downgraded SDL to 2.0.20 and it fixed the issue on both PCs. Therefore, I believe one of the recent commits is causing the issue.
@slouken slouken added this to the 2.0.24 milestone May 2, 2022
@complexlogic complexlogic mentioned this issue May 2, 2022
Closed
@ubitux
Copy link

ubitux commented May 2, 2022 •
edited

Can be reproduced with various other tools; ffplay (video player test from FFmpeg project) is one of them (f for fullscreen).

icculus added a commit that referenced this issue May 19, 2022
@icculus
x11: send move/resize events when waiting on fullscreen change.
9edd411 
Otherwise we ignore the Configure/etc events when they come in because
the window is already in an identical state as far as SDL is concerned.

Fixes #5593.

May also fix:
Issue #5572.
Issue #5595.
@icculus
Copy link
Collaborator

icculus commented May 19, 2022

@complexlogic Can you see if 9edd411 (the latest in main) fixes it for you?

sezero pushed a commit to sezero/SDL that referenced this issue May 19, 2022
@icculus @sezero
x11: send move/resize events when waiting on fullscreen change.
f7f0bf2 
Otherwise we ignore the Configure/etc events when they come in because
the window is already in an identical state as far as SDL is concerned.

Fixes libsdl-org#5593.

May also fix:
Issue libsdl-org#5572.
Issue libsdl-org#5595.
(cherry picked from commit 9edd411)
@complexlogic
Copy link
Author

I built main at the referenced commit, tested, and everything is working as it was before. Thanks.

slouken pushed a commit that referenced this issue May 20, 2022
@icculus @slouken
x11: send move/resize events when waiting on fullscreen change.
031c9b0 
Otherwise we ignore the Configure/etc events when they come in because
the window is already in an identical state as far as SDL is concerned.

Fixes #5593.

May also fix:
Issue #5572.
Issue #5595.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icculus icculus

Labels
None yet
Projects
None yet
Milestone
2.24.0
Development

No branches or pull requests
4 participants
@ubitux @icculus @slouken @complexlogic