SDL API renaming: *Is* functions

[slouken]

I am in the process of adding SDL_SetEventEnabled() and SDL_EventEnabled() instead of SDL_IsEventEnabled(), and I'm reviewing the other *Is* functions:

SDL_IsAndroidTV
SDL_IsChromebook
SDL_IsDeXMode
SDL_IsGamepad
SDL_IsGamepadConnected => SDL_GamepadConnected
SDL_IsGamepadSensorEnabled => SDL_GamepadSensorEnabled 
SDL_IsJoystickConnected => SDL_JoystickConnected
SDL_IsJoystickVirtual
SDL_IsPointInRect => SDL_PointInRect 
SDL_IsPointInRectF => SDL_PointInRectF 
SDL_IsRectEmpty => SDL_RectEmpty 
SDL_IsRectEmptyF => SDL_RectEmptyF
SDL_IsRenderClipEnabled => SDL_RenderClipEnabled
SDL_IsRenderTargetSupported => SDL_RenderTargetSupported
SDL_IsScreenKeyboardShown => SDL_ScreenKeyboardShown
SDL_IsScreenSaverEnabled => SDL_ScreenSaverEnabled 
SDL_IsShapedWindow
SDL_IsTablet
SDL_IsTextInputActive => SDL_TextInputActive
SDL_IsTextInputShown => SDL_TextInputShown
SDL_JoystickIsHaptic
SDL_MouseIsHaptic

I'm thinking about removing "Is" from any function that reads smoothly without it. e.g. leaving SDL_IsGamepad(), but changing SDL_GamepadConnected()

Thoughts?

@libsdl-org/a-team for discussion

[slouken]

Or maybe I should have made the functions SDL_SetEventEnabled() and SDL_GetEventEnabled() and leave these alone?

[slouken]

Although if (SDL_EventEnabled()) flows so much better...

[icculus]

I assume the haptic ones weren't changed because all of haptic is getting serious scrutiny outside of renaming.

"IsTablet" uses "is" as a form of "to be" ...like, the actual question is of its nature. They can stay.

The rest is just a superfluous word in the question and it flows as better English with if (RectEmpty) than if (IsRectEmpty)

[slouken]

Perfect, thanks!

[slouken]

I updated the original post with the proposed changes.

[slouken]

@icculus, these functions went back to their SDL2 names:

SDL_PointInRect
SDL_RectEmpty
SDL_RenderTargetSupported

[1vanK]

This renaming conflicts with other renamings. You delete Is but same time add Get (SDL_GetJoystickName for example).

C have no properties like C# and using Is, Get, Set is common practice

[1vanK]

Same time even C# have IsX() for boolean functions. Char.IsDigit() for example https://learn.microsoft.com/en-us/dotnet/api/system.char.isdigit?view=net-7.0