-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL 2.29.3: iOS incorrectly tries to use _iconv #8964
Comments
Fixed for release, thanks! |
thank you :) |
capehill
pushed a commit
to AmigaPorts/SDL
that referenced
this issue
Feb 2, 2024
Fixes libsdl-org#8964 (cherry picked from commit d6a48e4) (cherry picked from commit 8eed915)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After updating to SDL 2.29.3 from 2.28.0 DevilutionX fails to build for iOS.
I'm guessing this is related to 17e62ab
Setting SDL_SYSTEM_ICONV = OFF allowed the build to pass, but this was previously not necessary.
I'm guessing iOS should also be added to this line:
SDL/CMakeLists.txt
Line 244 in 8ce6fb2
Full buld log: https://github.com/diasurgical/devilutionX/actions/runs/7747939817/job/21129505080?pr=6920
The text was updated successfully, but these errors were encountered: