Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL 2.29.3: iOS incorrectly tries to use _iconv #8964

Closed
AJenbo opened this issue Feb 1, 2024 · 2 comments
Closed

SDL 2.29.3: iOS incorrectly tries to use _iconv #8964

AJenbo opened this issue Feb 1, 2024 · 2 comments

Comments

@AJenbo
Copy link
Contributor

AJenbo commented Feb 1, 2024

After updating to SDL 2.29.3 from 2.28.0 DevilutionX fails to build for iOS.

I'm guessing this is related to 17e62ab

Setting SDL_SYSTEM_ICONV = OFF allowed the build to pass, but this was previously not necessary.

I'm guessing iOS should also be added to this line:

if(WINDOWS)

clang: warning: overriding '-miphoneos-version-min=9.0' option with '-target aarch64-apple-ios11.0' [-Woverriding-t-option]
Undefined symbols for architecture arm64:
  "_iconv", referenced from:
      _SDL_iconv in libSDL2.a(SDL_iconv.c.o)
     (maybe you meant: _SDL_iconv_string, _SDL_iconv_open , _SDL_iconv_close , _SDL_iconv )
  "_iconv_close", referenced from:
      _SDL_iconv_close in libSDL2.a(SDL_iconv.c.o)
     (maybe you meant: _SDL_iconv_close)
  "_iconv_open", referenced from:
      _SDL_iconv_open in libSDL2.a(SDL_iconv.c.o)
     (maybe you meant: _SDL_iconv_open)
ld: symbol(s) not found for architecture arm64

Full buld log: https://github.com/diasurgical/devilutionX/actions/runs/7747939817/job/21129505080?pr=6920

@slouken slouken closed this as completed in d6a48e4 Feb 1, 2024
slouken added a commit that referenced this issue Feb 1, 2024
slouken added a commit that referenced this issue Feb 1, 2024
Fixes #8964

(cherry picked from commit d6a48e4)
(cherry picked from commit 8eed915)
@slouken
Copy link
Collaborator

slouken commented Feb 1, 2024

Fixed for release, thanks!

@AJenbo
Copy link
Contributor Author

AJenbo commented Feb 2, 2024

thank you :)

capehill pushed a commit to AmigaPorts/SDL that referenced this issue Feb 2, 2024
Fixes libsdl-org#8964

(cherry picked from commit d6a48e4)
(cherry picked from commit 8eed915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants