Cast all SDL_Keycode types to common type #10070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in the middle of a bunch of keyboard changes, so please hold off on this for now. I do plan to address #10020 as part of that work. |
|
Ok I'll wait -- do you have something I can watch for updates? I'm not very active in discord etc.. |
|
Yep, check this out: |
slouken
added a commit
to slouken/SDL
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to resolve issue #10020
I want to contribute back to SDL as it's the backbone of my project, this is my attempt to either resolve or jump start a conversation about resolving this issue.
Description
The first commit vertically aligns all type definitions to make it easier to read.
The second commit casts the definitions to SDL_Keycode in order to remove errors when comparing SDL_Keycode values against the raw values directly.
Existing Issue(s)
#10020