wayland: Only dispatch frame events in Wayland_GLES_SwapWindow #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dispatching all events in Wayland_GLES_SwapWindow leads to resizes being acked before the program has a chance to handle the resize. This change reduces jumping on fullscreen transition with apps that call SDL_PollEvent before issuing any render calls.
|
Will test this now, but at a glance I'm now realizing we shouldn't be dispatching the whole display anyway since that probably causes conflicts with other queues (would certainly explain why Transistor likes to hang so much). Even if the timing is still wrong, that part is probably worth applying anyway. |
flibitijibibo
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Seems to work for me, sadly doesn't fix Transistor or #4571 like I hoped it would but this is still a good idea.
|
CC @dos1, does this fix the Weston error? |
|
It does not - and I don't see how it could given the wayland-egl behavior observed in #4563. However, this is not a reason to not accept this change ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatching all events in Wayland_GLES_SwapWindow leads to resizes being acked before the program has a chance to handle the resize. This change reduces jumping on fullscreen transition with apps that call SDL_PollEvent before issuing any render calls.
Existing Issue(s)
Related to #4563