Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in IMU calibration loading for Nintendo Controllers #6394

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

happyharryh
Copy link
Contributor

Description

When I test the sensors of my Nintendo controllers, I find:

For Pro Controller, accel_x is about 1.3 times of the normal value
For Joy-Con(L) in mini-pad mode, accel_y and accel_z are about 1.3 times of the normal value

I'm not sure if the cause is the mistake in the bitwise operations in LoadIMUCalibration. Anyway, after I changed 0xF00 to 0xFF00 in the code, the sensor data became normal. So, please have a check.

@slouken
Copy link
Collaborator

slouken commented Oct 15, 2022

This is correct, thanks!

@slouken slouken merged commit a6573f9 into libsdl-org:main Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants