SDL_GetRenderer: don't report a renderer when it's for internal use #7795
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we want to do this. Using a renderer and a window surface are incompatible, and documented as such. The real question is why a window surface was created in the original bug report at pygame-community/pygame-ce#2190 |
|
Okay, I added functions for the next SDL release that will let you check whether a window surface has been created, and destroy it if you want to switch between 2D renderer and using the window surface. I also made creating a renderer fail if the window has a surface associated with it, so the limitation is more clear. :) This should allow the pygame folks to do cleaner handling of this case in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL_GetRenderer: don't report a renderer when it's for internal use
see #7793