-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emscripten: Add JS library dependencies using EM_JS_DEPS macro #7935
Conversation
9ec0d56
to
7f8ade0
Compare
Oh wow, I've been bit by this problem myself; I saw this was force-pushed a few times; let me know when you're done and I'll merge this! |
I'm done if the CI passes! |
GitHub seems to be having a build-farm issue at the moment, but we'll get this in when they fix it. :) |
Are the changes not needed in SDL3 ? |
Oh, whoops, I thought this was SDL3. I'll cherry-pick it over. |
Sorry, whats the policy on committing to with SDL2 vs main branch? |
In general development goes into SDL3, and is cherry picked into SDL2, but we're flexible. |
This is in for SDL3 in b42cb1c; should we kick this into 2.28.2, as well? |
No, let's leave it as-is for 2.28.1 unless it's critical. |
I think this is safe to merge in release-2.28 branch so it gets in a 2.28.5 release. |
This is already in the 2.28.4 release. |
Ah, ok, found the commit, it was in September: Thank you! |
See emscripten-core/emscripten#19780