Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More keyboard improvements #9363

Merged
merged 3 commits into from Mar 26, 2024
Merged

More keyboard improvements #9363

merged 3 commits into from Mar 26, 2024

Conversation

slouken
Copy link
Collaborator

@slouken slouken commented Mar 25, 2024

Enable raw keyboard events on Windows by default

Added support for events from distinct keyboards

@slouken slouken force-pushed the raw-keyboard branch 4 times, most recently from b94cd1d to f7d78bb Compare March 26, 2024 03:17
@slouken slouken merged commit 3dfc3b4 into libsdl-org:main Mar 26, 2024
35 checks passed
@slouken slouken deleted the raw-keyboard branch March 26, 2024 03:41
@sezero
Copy link
Contributor

sezero commented Mar 26, 2024

Applied 693c75e to fix linkage if Xinput2 isn't available

@slouken
Copy link
Collaborator Author

slouken commented Mar 26, 2024

Thanks!

@0x1F9F1
Copy link
Collaborator

0x1F9F1 commented Mar 26, 2024

Started getting some crashes in WIN_PollRawInput after this. I think because it assumes all events are of size data->rawinput_size, which is no longer true.

Edit: Maybe this should've been #9361

@slouken
Copy link
Collaborator Author

slouken commented Mar 26, 2024

Started getting some crashes in WIN_PollRawInput after this. I think because it assumes all events are of size data->rawinput_size, which is no longer true.

Fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants