Skip to content

Commit

Permalink
minimp3: remove TAG+ support
Browse files Browse the repository at this point in the history
It's a still-born extension that no one uses, no player
supports, and no tag library parses.

And it's not impossible to hit it as a false positive..

(The removal has already been suggested to mainstream at
lieff/minimp3#66)

(cherry picked from commit f9933b5)
  • Loading branch information
sezero authored and slouken committed Jan 14, 2024
1 parent dd55137 commit 532013b
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/codecs/minimp3/minimp3_ex.h
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,7 @@ static void mp3dec_skip_id3v1(const uint8_t *buf, size_t *pbuf_size)
size_t buf_size = *pbuf_size;
#ifndef MINIMP3_NOSKIP_ID3V1
if (buf_size >= 128 && !memcmp(buf + buf_size - 128, "TAG", 3))
{
buf_size -= 128;
if (buf_size >= 227 && !memcmp(buf + buf_size - 227, "TAG+", 4))
buf_size -= 227;
}
#endif
#ifndef MINIMP3_NOSKIP_APEV2
if (buf_size > 32 && !memcmp(buf + buf_size - 32, "APETAGEX", 8))
Expand Down

0 comments on commit 532013b

Please sign in to comment.