build: add/fix Requires.private packages in libssh2.pc
#1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autotools was using `libwolfssl`. CMake left it empty. The `.pc` file provided by wolfSSL is called `wolfssl.pc`. This patch sets `Requires.private: wolfssl` with both build tools. Not tested. Closes libssh2#1123
https://github.com/gpg/libgcrypt/blob/e76e88eef7811ada4c6e1d57520ba8c439139782/src/libgcrypt.pc.in Present since 2005-04-22 gpg/libgcrypt@32bf3f1, released in 1.3.0 2007-05-04 https://github.com/gpg/libgcrypt/releases/tag/libgcrypt-1.3.0
vszakats
changed the title
Requires.private for wolfSSL in libssh2.pcRequires.private for wolfSSL/libgcrypt in libssh2.pc
Also delete just added lib dedupe, it's now redundant. Ref: 2fc3679
vszakats
changed the title
Requires.private for wolfSSL/libgcrypt in libssh2.pcRequires.private packages in libssh2.pc
lampmanyao
pushed a commit
to lampmanyao/libssh2
that referenced
this pull request
Sep 3, 2023
- autotools was using `libwolfssl`. CMake left it empty. wolfSSL
provides `wolfssl.pc`. This patch sets `Requires.private: wolfssl`
with both build tools.
- add `libgcrypt` to `Requires.private` with both autotools and CMake.
Ref:
https://github.com/gpg/libgcrypt/blob/e76e88eef7811ada4c6e1d57520ba8c439139782/src/libgcrypt.pc.in
Present since 2005-04-22:
gpg/libgcrypt@32bf3f1
Released in v1.3.0 2007-05-04:
https://github.com/gpg/libgcrypt/releases/tag/libgcrypt-1.3.0
- also stop adding transitive `zlib` deps to `Requires.private`.
The referenced crypto package is adding it as nedded.
This makes deduplication of the list redundant, so stop doing it.
Follow-up to 2fc3679
(`libssh2.pc` not tested as a project dependency.)
Closes libssh2#1123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autotools was using
libwolfssl. CMake left it empty. wolfSSLprovides
wolfssl.pc. This patch setsRequires.private: wolfsslwith both build tools.
add
libgcrypttoRequires.privatewith both autotools and CMake.Ref:
https://github.com/gpg/libgcrypt/blob/e76e88eef7811ada4c6e1d57520ba8c439139782/src/libgcrypt.pc.in
Present since 2005-04-22:
gpg/libgcrypt@32bf3f1
Released in v1.3.0 2007-05-04:
https://github.com/gpg/libgcrypt/releases/tag/libgcrypt-1.3.0
also stop adding transitive
zlibdeps toRequires.private.The referenced crypto package is adding it as nedded.
This makes deduplication of the list redundant, so stop doing it.
Follow-up to 2fc3679
(
libssh2.pcnot tested as a project dependency.)