New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libssh2.pc: re-add & extend support for static-only libssh2 builds #1119
Conversation
Misc observations comparing
Ref: |
Libs:
for static buildsLibs:
for static-only builds
Libs:
for static-only buildsLibs:
for static-only builds
Quoting the curl commit message (adapted for libssh2): "A project being built entirely statically will call pkg-config with `--static`, which utilises the `Libs.private` field. Conversely it will not use `--static` when not being built entirely statically, even if there is only a static build of libssh2 available. This will most likely cause the build to fail due to underlinking unless we merge the `Libs` fields. Consider that this is what the Meson build system does when it generates pkg-config files." Follow-up to 1209c16 libssh2#1114 Ref: curl/curl@98e5904 Ref: curl/curl#5373 Closes libssh2#1119
b15a180
to
67d222b
Compare
Libs:
for static-only buildsLibs:
for static-only builds
This comment was marked as outdated.
This comment was marked as outdated.
Libs:
for static-only buildsLibs:
for static-only builds
Quoting the curl commit message (adapted for libssh2): "A project being built entirely statically will call pkg-config with `--static`, which utilises the `Libs.private` field. Conversely it will not use `--static` when not being built entirely statically, even if there is only a static build of libssh2 available. This will most likely cause the build to fail due to underlinking unless we merge the `Libs` fields. Consider that this is what the Meson build system does when it generates pkg-config files." Follow-up to 1209c16 libssh2#1114 Ref: curl/curl@98e5904 Ref: curl/curl#5373 Closes libssh2#1119
67d222b
to
ada9a97
Compare
Quoting the curl commit message (adapted for libssh2): "A project being built entirely statically will call pkg-config with `--static`, which utilises the `Libs.private` field. Conversely it will not use `--static` when not being built entirely statically, even if there is only a static build of libssh2 available. This will most likely cause the build to fail due to underlinking unless we merge the `Libs` fields. Consider that this is what the Meson build system does when it generates pkg-config files." Follow-up to 1209c16 libssh2#1114 Ref: curl/curl@98e5904 Ref: curl/curl#5373 Closes libssh2#1119
ada9a97
to
8dbc258
Compare
Libs:
for static-only builds92af986
to
e0b0cb7
Compare
Adapted for libssh2 from the curl commit message by James Le Cuirot: "A project built entirely statically will call `pkg-config` with `--static`, which utilises the `Libs.private:` field. Conversely it will not use `--static` when not being built entirely statically, even if there is only a static build of libssh2 available. This will most likely cause the build to fail due to underlinking unless we merge the `Libs:` fields. Consider that this is what the Meson build system does when it generates `pkg-config` files." This patch extends the above to `Requires:`, to mirror `Libs:` with `pkg-config` package names. Follow-up to 1209c16 libssh2#1114 Ref: libssh2#1114 (comment) Ref: curl/curl@98e5904 Ref: curl/curl#5373 Closes libssh2#1119
Adapted for libssh2 from the curl commit message by James Le Cuirot:
"A project built entirely statically will call
pkg-config
with--static
, which utilises theLibs.private:
field. Conversely it willnot use
--static
when not being built entirely statically, even ifthere is only a static build of libssh2 available. This will most
likely cause the build to fail due to underlinking unless we merge the
Libs:
fields.Consider that this is what the Meson build system does when it generates
pkg-config
files."This patch extends the above to
Requires:
, to mirrorLibs:
withpkg-config
package names.Follow-up to 1209c16 #1114
Ref: #1114 (comment)
Ref: curl/curl@98e5904
Ref: curl/curl#5373
Closes #1119