autotools: use comma separator in Requires.private of libssh2.pc
#1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spaces also seem to work, but the documented separator is comma, which was already used by the CMake-generated `libssh2.pc`. Adjust the autotools-generated one to use commas too. Ref: https://linux.die.net/man/1/pkg-config Ref: https://gitlab.freedesktop.org/pkg-config/pkg-config/-/blob/d97db4fae4c1cd099b506970b285dc2afd818ea2/pkg-config.1 Closes libssh2#1124
vszakats
changed the title
Requires.private in libssh2.pcRequires.private of libssh2.pc
vszakats
changed the title
Requires.private of libssh2.pcRequires.private of libssh2.pc
lampmanyao
pushed a commit
to lampmanyao/libssh2
that referenced
this pull request
Sep 3, 2023
In `Requires*:`, the documented name separator is comma. We already used it in the CMake-generated `libssh2.pc`. Adjust the autotools-generated one to use it too, instead of spaces. Ref: https://linux.die.net/man/1/pkg-config Ref: https://gitlab.freedesktop.org/pkg-config/pkg-config/-/blob/d97db4fae4c1cd099b506970b285dc2afd818ea2/pkg-config.1 Closes libssh2#1124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Requires*:, the documented name separator is comma. We already usedit in the CMake-generated
libssh2.pc. Adjust the autotools-generatedone to use it too, instead of spaces.
Ref: https://linux.die.net/man/1/pkg-config
Ref: https://gitlab.freedesktop.org/pkg-config/pkg-config/-/blob/d97db4fae4c1cd099b506970b285dc2afd818ea2/pkg-config.1
Closes #1124