Generate debug info when building with MSVC

[jethrogb]

I'm not sure why the Visual Studio generators wouldn't do this automatically. I copied what libgit2 is doing.

[mention-bot]

@jethrogb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alamaison, @wildart and @dbyron0 to be potential reviewers.

[jethrogb]

@alamaison @wildart @dbyron0 ping

[dbyron0]

Sorry, I imagine this is right but know very little about cmake.

[jethrogb]

@alamaison @wildart @dbyron0 ping

[alamaison]

Don't you just need to switch to the Debug or RelWithDebugInfo configuration in the generated visual studio project?

[jethrogb]

It's been a long time. I think I tried that but it didn't work. Do you want me to check again?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jethrogb]

Instead of marking it stale, maybe just merge it?

[bagder]

Anyone (else) building on Windows who can say something 👍 or 👎 about this PR?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jethrogb]

not stale

[willco007]

@jethrogb did you happen to test the suggestion from @alamaison about changing the project configuration?

[jethrogb]

Ok I finally booted into Windows to test this flow again. I'm not using the graphical Visual Studio interface to build anything. I'm just using CMake for the entire build (with the Visual Studio backend). I confirmed that it still doesn't generate symbols without this change.