Bcrypt #497
Merged
Bcrypt #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaeckel
force-pushed
the
bcrypt
branch
7 times, most recently
from
72736b1
to
fa23a84
Compare
sjaeckel
added a commit
that referenced
this pull request
Sep 24, 2019
Now `make LTC_DEBUG=1` builds a full-speed library but with debug infos. One has to do `make LTC_DEBUG=1 IGNORE_SPEED=1` now to have the same results as before. This was done since 1. it makes sense to enable optimization also when adding debug infos 2. clang+valgrind creates errors if there's no optimization enabled (c.f. #497)
sjaeckel
added a commit
that referenced
this pull request
Sep 29, 2019
Now `make LTC_DEBUG=1` builds a full-speed library but with debug infos. One has to do `make LTC_DEBUG=1 IGNORE_SPEED=1` now to have the same results as before. This was done since 1. it makes sense to enable optimization also when adding debug infos 2. clang+valgrind creates errors if there's no optimization enabled (c.f. #497)
karel-m
reviewed
Sep 29, 2019
sjaeckel
added a commit
that referenced
this pull request
Sep 30, 2019
Now `make LTC_DEBUG=1` builds a full-speed library but with debug infos. One has to do `make LTC_DEBUG=1 IGNORE_SPEED=1` now to have the same results as before. This was done since 1. it makes sense to enable optimization also when adding debug infos 2. clang+valgrind creates errors if there's no optimization enabled (c.f. #497)
Merged
When compiling with "-g -O0" valgrind complained about "Conditional jump or move depends on uninitialised value(s)", c.f. e.g. [1] [1] https://travis-ci.org/libtom/libtomcrypt/jobs/588690930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the bcrypt password-based hashing algorithm.Add the bcrypt PBKDF algorithm as used when encrypting OpenSSH key files.
Checklist