Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements #499

Merged
merged 9 commits into from
Sep 30, 2019
Merged

Minor improvements #499

merged 9 commits into from
Sep 30, 2019

Conversation

sjaeckel
Copy link
Member

  • add more rotate intrinsics
  • speed up the build of PR's
  • minor changes of makefiles

Copy link
Member

@karel-m karel-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I am fine with the changes. Any idea why coverage/coveralls failed?

* unignore type-limits warning
* add the possibility to do `make V=0 >/dev/null` and still get the
  CFLAGS and LDFLAGS that are used while compilation
all the other builds are only get built, the testrun is skipped
clang-9 brings `scan-build-py-9` which matched the old pattern
Now `make LTC_DEBUG=1` builds a full-speed library but with debug infos.

One has to do `make LTC_DEBUG=1 IGNORE_SPEED=1` now to have the same
results as before.

This was done since
1. it makes sense to enable optimization also when adding debug infos
2. clang+valgrind creates errors if there's no optimization enabled
   (c.f. #497)
@sjaeckel
Copy link
Member Author

Any idea why coverage/coveralls failed?

because my patch wasn't complete... :-)

I cherry-picked some more commits from #497 as they didn't belong there in the first place and that we can see if the difference in coverage is only by the change of the gcc version used!

@sjaeckel
Copy link
Member Author

I would say that the results of travis build 1845.1 and its coveralls results which were still on Trusty/gcc 4.8.5 vs. build 1846.1 and its coveralls results which are now on Bionic/gcc 7.4.0 indicate that the drop of coverage by 0.4% is caused by the new version of gcc, or am I mistaken?

@sjaeckel sjaeckel merged commit 734ba7e into develop Sep 30, 2019
@sjaeckel sjaeckel deleted the minor-improvements branch September 30, 2019 13:00
@karel-m karel-m mentioned this pull request Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants