-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HID Report Parser for HIDAPI #585
Comments
The parsing code needed to fix #274 will be about 50 lines of code. This does not require a full blown ReportDescriptor parser. Line 270 in a88805e
the code to determine the report size per ReportId could be integrated here, than we would need to add even less lines of code. |
So you are basically saying it is not that difficult to fix #274 and we do not need to use the GPL codes at all. Glad to hear that. |
BTW, the old libhid has a GPL licensed hid parser as well. I even keep a Windows port here. hidrd is also GPL licensed. |
This Python HID parser has MIT license. This C based parser does not seem to be so complete, with MIT license as well. This Python based HID/PID Report Descriptor parser is more complete, not so sure about the license. |
My oppinion of having the HID Descriptor parser inside HIDAPI is the same: not much point having such, definitely not as a part of this repo (even in a branch). There're multiple existing implementation (thank you @mcuee for examples above), and if someone needs any of those - there are multiple options to choose from. And in the context of #274 - I agree, that minimally extending the existing parser would make the best sense, as @JoergAtGithub described above. |
In this case I will close this issue. |
Reference:
The main hidapi tree will maintain the exting licenses (triple licenses). The exising HID Report Parser in the SuperCollider fork is using GPL so it can not be directly used.
One potential way is to have a branch or a new repo to host that integration if some one is interested and if they are okay with GPL license.
The text was updated successfully, but these errors were encountered: