Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: uv_fs_{open,read,close}_dir (or whatever is necessary for a streaming fs.readdir() in node) #170

Closed
jonathanong opened this issue Jan 28, 2015 · 8 comments
Closed

fs: uv_fs_{open,read,close}_dir (or whatever is necessary for a streaming fs.readdir() in node) #170

jonathanong opened this issue Jan 28, 2015 · 8 comments

Comments

@jonathanong
Copy link

i'd like nodejs/node#583. seems like it requires joyent/libuv#1574, but i don't see that as a PR int his repo.

you can close this if this is already in. can't really help with a PR in C++ land. just a feature request :)
@saghul
Copy link
Member

saghul commented Jan 28, 2015

@misterdjules mind reopening your PR here? Thanks!

@vkurchatkin
Copy link

👍

@misterdjules
Copy link

@saghul Yes, I'll do that later, hopefully today and for sure before the end of this week!

@jonathanong
Copy link
Author

👍

@vkurchatkin
Copy link

@misterdjules thank you! Once it's in io.js I volunteer to implement both sync and async bindings

@saghul
Copy link
Member

saghul commented Jan 28, 2015

Thank you all!

misterdjules pushed a commit to misterdjules/libuv-1 that referenced this issue Jan 30, 2015
fs: uv_fs_{open,read,close}_dir
f7891c5 
Tested on Linux, MacOS X, SmartOS and Windows.

Fixes libuv#170.
misterdjules pushed a commit to misterdjules/libuv-1 that referenced this issue Jan 30, 2015
fs: uv_fs_{open,read,close}_dir
e0a2fd5 
This is the same changes as joyent/libuv#1574.
This commit is just the start of getting them to work in libuv/libuv.

Failing tests will be fixed asap.

Fixes libuv#170.
@misterdjules misterdjules mentioned this issue Jan 30, 2015
Closed
@misterdjules
Copy link

The PR is up. This is a work in progress, I'll update it asap so that all tests pass, and then we can discuss it further. Thank you!

@saghul
Copy link
Member

saghul commented Jan 30, 2015

Fantastic! Let's continue the discussion there then.

@saghul saghul closed this as completed Jan 30, 2015
whitlockjc pushed a commit to whitlockjc/libuv that referenced this issue Jun 30, 2015
@whitlockjc
fs: uv_fs_{open,read,close}_dir
10b03ef 
This is the same changes as joyent/libuv#1574.
This commit is just the start of getting them to work in libuv/libuv.

Failing tests will be fixed asap.

Fixes libuv#170.
@domenic domenic mentioned this issue Jul 16, 2015
Open
whitlockjc pushed a commit to whitlockjc/libuv that referenced this issue Aug 19, 2015
@whitlockjc
fs: uv_fs_{open,read,close}_dir
99ef9fe 
This is the same changes as joyent/libuv#1574.
This commit is just the start of getting them to work in libuv/libuv.

Failing tests will be fixed asap.

Fixes libuv#170.
whitlockjc pushed a commit to whitlockjc/libuv that referenced this issue Aug 10, 2016
@whitlockjc
fs: uv_fs_{open,read,close}_dir
7ac0bad 
This is the same changes as joyent/libuv#1574.
This commit is just the start of getting them to work in libuv/libuv.

Failing tests will be fixed asap.

Fixes libuv#170.
whitlockjc pushed a commit to whitlockjc/libuv that referenced this issue Dec 22, 2016
@whitlockjc
fs: uv_fs_{open,read,close}_dir
c6a823e 
This is the same changes as joyent/libuv#1574.
This commit is just the start of getting them to work in libuv/libuv.

Failing tests will be fixed asap.

Fixes libuv#170.
whitlockjc pushed a commit to whitlockjc/libuv that referenced this issue Apr 14, 2018
@whitlockjc
fs: uv_fs_{open,read,close}_dir
0de528a 
This is the same changes as joyent/libuv#1574.
This commit is just the start of getting them to work in libuv/libuv.

Failing tests will be fixed asap.

Fixes libuv#170.
whitlockjc pushed a commit to whitlockjc/libuv that referenced this issue Apr 14, 2018
@whitlockjc
fs: uv_fs_{open,read,close}_dir
3702801 
This is the same changes as joyent/libuv#1574.
This commit is just the start of getting them to work in libuv/libuv.

Failing tests will be fixed asap.

Fixes libuv#170.
whitlockjc pushed a commit to whitlockjc/libuv that referenced this issue Apr 15, 2018
@whitlockjc
fs: uv_fs_{open,read,close}_dir
d423bb2 
This is the same changes as joyent/libuv#1574
but reworked for libuv/libuv.

This commit also updates `uv__fs_readdir` to use `readdir` instead of
the deprecated `readdir_r`.

Fixes libuv#170.
whitlockjc pushed a commit to whitlockjc/libuv that referenced this issue Apr 16, 2018
@whitlockjc
fs: uv_fs_{open,read,close}_dir
45c1266 
This is the same changes as joyent/libuv#1574
but reworked for libuv/libuv.

This commit also updates `uv__fs_readdir` to use `readdir` instead of
the deprecated `readdir_r`.

Fixes libuv#170.
cjihrig added a commit to cjihrig/libuv that referenced this issue Oct 27, 2018
@cjihrig @whitlockjc
unix,win: add uv_fs_{open,read,close}_dir()
20ec85d 
This commit also updates `uv__fs_readdir` to use `readdir` instead of
the deprecated `readdir_r`.

Co-authored-by: Julien Gilli <jgilli@nodejs.org>
Co-authored-by: Jeremy Whitlock <jwhitlock@apache.org>
Refs: joyent/libuv#1430
Refs: joyent/libuv#1521
Refs: joyent/libuv#1574
Refs: libuv#175
Refs: nodejs/node#583
Refs: libuv#416
Refs: libuv#170
cjihrig added a commit to cjihrig/libuv that referenced this issue Oct 29, 2018
@cjihrig @whitlockjc
unix,win: add uv_fs_{open,read,close}_dir()
ffd8449 
This commit also updates `uv__fs_readdir()` to use `readdir()`
instead of the deprecated `readdir_r()`.

Co-authored-by: Julien Gilli <jgilli@nodejs.org>
Co-authored-by: Jeremy Whitlock <jwhitlock@apache.org>
Refs: joyent/libuv#1430
Refs: joyent/libuv#1521
Refs: joyent/libuv#1574
Refs: libuv#175
Refs: nodejs/node#583
Refs: libuv#416
Refs: libuv#170
Fishrock123 pushed a commit to Fishrock123/libuv that referenced this issue Feb 11, 2019
@cjihrig @whitlockjc @Fishrock123
unix,win: add uv_fs_{open,read,close}_dir()
91e5a09 
This commit also updates `uv__fs_readdir()` to use `readdir()`
instead of the deprecated `readdir_r()`.

Co-authored-by: Julien Gilli <jgilli@nodejs.org>
Co-authored-by: Jeremy Whitlock <jwhitlock@apache.org>
Refs: joyent/libuv#1430
Refs: joyent/libuv#1521
Refs: joyent/libuv#1574
Refs: libuv#175
Refs: nodejs/node#583
Refs: libuv#416
Refs: libuv#170
cjihrig added a commit to cjihrig/libuv that referenced this issue Mar 19, 2019
@cjihrig @whitlockjc
unix,win: add uv_fs_{open,read,close}_dir()
778799f 
This commit also updates `uv__fs_readdir()` to use `readdir()`
instead of the deprecated `readdir_r()`.

Co-authored-by: Julien Gilli <jgilli@nodejs.org>
Co-authored-by: Jeremy Whitlock <jwhitlock@apache.org>
Refs: joyent/libuv#1430
Refs: joyent/libuv#1521
Refs: joyent/libuv#1574
Refs: libuv#175
Refs: nodejs/node#583
Refs: libuv#416
Refs: libuv#170
cjihrig added a commit to cjihrig/libuv that referenced this issue Mar 24, 2019
@cjihrig @whitlockjc
unix,win: add uv_fs_{open,read,close}dir()
177b17d 
Co-authored-by: Julien Gilli <jgilli@nodejs.org>
Co-authored-by: Jeremy Whitlock <jwhitlock@apache.org>
Refs: joyent/libuv#1430
Refs: joyent/libuv#1521
Refs: joyent/libuv#1574
Refs: libuv#175
Refs: nodejs/node#583
Refs: libuv#416
Refs: libuv#170
cjihrig added a commit to cjihrig/libuv that referenced this issue Mar 26, 2019
@cjihrig @whitlockjc
unix,win: add uv_fs_{open,read,close}dir()
d9ec47a 
Co-authored-by: Julien Gilli <jgilli@nodejs.org>
Co-authored-by: Jeremy Whitlock <jwhitlock@apache.org>
Refs: joyent/libuv#1430
Refs: joyent/libuv#1521
Refs: joyent/libuv#1574
Refs: libuv#175
Refs: nodejs/node#583
Refs: libuv#416
Refs: libuv#170
cjihrig added a commit to cjihrig/libuv that referenced this issue Mar 26, 2019
@cjihrig @whitlockjc
unix,win: add uv_fs_{open,read,close}dir()
f570ec8 
Co-authored-by: Julien Gilli <jgilli@nodejs.org>
Co-authored-by: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: libuv#2057
Refs: joyent/libuv#1430
Refs: joyent/libuv#1521
Refs: joyent/libuv#1574
Refs: libuv#175
Refs: nodejs/node#583
Refs: libuv#416
Refs: libuv#170
cjihrig added a commit to cjihrig/libuv that referenced this issue Mar 26, 2019
@cjihrig @whitlockjc
unix,win: add uv_fs_{open,read,close}dir()
99440bb 
Co-authored-by: Julien Gilli <jgilli@nodejs.org>
Co-authored-by: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: libuv#2057
Refs: joyent/libuv#1430
Refs: joyent/libuv#1521
Refs: joyent/libuv#1574
Refs: libuv#175
Refs: nodejs/node#583
Refs: libuv#416
Refs: libuv#170
njlr pushed a commit to buckaroo-pm/libuv that referenced this issue Apr 5, 2019
@cjihrig @whitlockjc @njlr
unix,win: add uv_fs_{open,read,close}dir()
3f76d58 
Co-authored-by: Julien Gilli <jgilli@nodejs.org>
Co-authored-by: Jeremy Whitlock <jwhitlock@apache.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: libuv#2057
Refs: joyent/libuv#1430
Refs: joyent/libuv#1521
Refs: joyent/libuv#1574
Refs: libuv#175
Refs: nodejs/node#583
Refs: libuv#416
Refs: libuv#170
Crunkle pushed a commit to Crunkle/libuv that referenced this issue Aug 8, 2019
@andrewrk
Merge pull request libuv#170 from GoaLitiuM/master
b5e37d1 
Add missing GUID for ISimpleAudioVolume
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fs: uv_fs_{open,read,close}_dir misterdjules/libuv-1
4 participants
@saghul @jonathanong @misterdjules @vkurchatkin